Skip to content

Conversation

juanitorduz
Copy link
Contributor

@juanitorduz juanitorduz commented Aug 17, 2025

Closes #1587

The content is essentially the same as the original notebook, up to one aspect: I removed the last example as it needs pytensor-ml. I think we can have two notebooks instead of a few long ones :)


📚 Documentation preview 📚: https://pytensor--1588.org.readthedocs.build/en/1588/

@juanitorduz juanitorduz marked this pull request as draft August 17, 2025 09:46
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz self-assigned this Aug 17, 2025
@juanitorduz juanitorduz marked this pull request as ready for review August 17, 2025 18:46
Copy link
Member

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on splitting the notebook, also the last example didn't end up working, so that's not so good :)

@juanitorduz juanitorduz merged commit 808528e into pymc-devs:main Sep 5, 2025
18 checks passed
@juanitorduz juanitorduz deleted the docs/normalizing_flows_example branch September 5, 2025 18:16
@ricardoV94
Copy link
Member

wasn't one of the examples not succeeding? Was it the removed one?

@jessegrabowski
Copy link
Member

Yes, the one that didn't work was cut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Normalizing Flows in PyTensor Notebook
3 participants